[TS] Add option for removing typescript import flag using --ts-no-import-ext #7748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
|
@bjornharrtell for comment |
|
I would like it so that this doesn't change current behavior, instead opt out of import extensions. Flag name should probably be including ts, so I would suggest |
ink-su
changed the title
bjornharrtell
approved these changes
Jan 7, 2023
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Jan 9, 2023
Co-authored-by: Derek Bailey <[email protected]>
4 tasks
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Derek Bailey <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Derek Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an flag
--ts-no-import-extto flatc to allow removing the import extension for typescript files.---ts-no-import-extimports will not have the.jsextension.Added test using
optional_scalars.fbsas the base.Fixes this issue which I also encountered in my NextJS project:
#7661