Skip to content

PUBLIC: Stop flagging @Ignore on JUnit3 tests. Internally, we've made our legacy JUnit3 runner skip tests with @Ignore (unknown commit). Externally, basically nobody uses JUnit3 anymore (and if someone does make this mistake, they'll quickly notice anyways). #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 10, 2026
+1 −44
Merged

PUBLIC: Stop flagging @Ignore on JUnit3 tests. Internally, we've made our legacy JUnit3 runner skip tests with @Ignore (unknown commit). Externally, basically nobody uses JUnit3 anymore (and if someone does make this mistake, they'll quickly notice anyways). #5952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions core/src/main/java/com/google/errorprone/bugpatterns/JUnit4ClassUsedInJUnit3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,7 @@ public Description matchAnnotation(AnnotationTree tree, VisitorState state) {
if (!enclosingClass(isJUnit3TestClass).matches(tree, state)) {
return NO_MATCH;
}
// If we are inside a JUnit3 test class some annotation should not appear.
if (isType("org.junit.Ignore").matches(tree, state)) {
return makeDescription("@Ignore", tree);
}
// If we are inside a JUnit3 test class some annotations should not appear.
if (isType("org.junit.Rule").matches(tree, state)) {
return makeDescription("@Rule", tree);
}
Expand Down
40 changes: 0 additions & 40 deletions core/src/test/java/com/google/errorprone/bugpatterns/JUnit4ClassUsedInJUnit3Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,46 +197,6 @@ public void testName3() {}
.doTest();
}

@Test
public void positive_ignore_on_test() {
compilationHelper
.addSourceLines(
"Foo.java",
"""
import junit.framework.TestCase;
import org.junit.Ignore;

public class Foo extends TestCase {
public void testName1() {}

// BUG: Diagnostic contains: @Ignore
@Ignore
public void testName2() {}
}
""")
.doTest();
}

@Test
public void positive_ignore_on_class() {
compilationHelper
.addSourceLines(
"Foo.java",
"""
import junit.framework.TestCase;
import org.junit.Ignore;

// BUG: Diagnostic contains: @Ignore
@Ignore
public class Foo extends TestCase {
public void testName1() {}

public void testName2() {}
}
""")
.doTest();
}

@Test
public void positive_rule_in_junit3() {
compilationHelper
Expand Down
Loading