Skip to content

Add Chinese translation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Chinese translation #12

wants to merge 1 commit into from

Conversation

xindoo
Copy link

@xindoo xindoo commented Sep 16, 2019

We are translating this document into Chinese for Chinese developers, and you can also see it on https://eng-practices-cn.xindoo.xyz/

We are translating this document into Chinese for Chinese developers, and you can also see it on https://eng-practices-cn.xindoo.xyz/
@rootsongjc
Copy link

rootsongjc commented Sep 16, 2019

I also translated it into Chinese with the same theme. I have finished it.
Github: https://github.com/rootsongjc/eng-practices
Github Pages: https://jimmysong.io/eng-practices/
If you think it's Ok I can submit a PR to merge the Chinese into the upstream.

@xindoo
Copy link
Author

xindoo commented Sep 16, 2019

I also translated it into Chinese with the same theme. I have finished it.
Github: https://github.com/rootsongjc/eng-practices
Github Pages: https://jimmysong.io/eng-practices/
If you think it's Ok I can submit a PR to merge the Chinese into the upstream.

Actually, we've built a translation team, and I think we can do better than you.

@adambender
Copy link
Collaborator

Hey all, code review can be hard enough, lets keep the comments positive please :)

As mentioned on the earlier prI am keen to get a translation if possible but need to find someone at Google who can confirm the quality.

Since the other translation request came first Im going to close this one. Though we might review both at some point.

Thanks for the effort, Im sure this wasn't easy!

@adambender adambender closed this Sep 18, 2019
@xindoo xindoo deleted the patch-1 branch September 20, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants