Fix heap overflow in CopyDataAsFloatImpl by validating accessor bounds - #1214
Open
ztzat089-ctrl wants to merge 1 commit into
Open
Fix heap overflow in CopyDataAsFloatImpl by validating accessor bounds#1214ztzat089-ctrl wants to merge 1 commit into
ztzat089-ctrl wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Hello Google, please investigate and verify this vulnerability. Thank you very much. |
ztzat089-ctrl
commented
Aug 10, 2026
ztzat089-ctrl
left a comment
Author
There was a problem hiding this comment.
Hello Google, please investigate and verify this vulnerability. Thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a heap buffer overflow (out-of-bounds read) in
CopyDataAsFloatImpl() in tiny_gltf_utils.h. The function did not
validate accessor.count, byte_stride, or buffer offsets before
reading data, which could allow reading beyond the allocated buffer
when processing a maliciously crafted glTF file.
This issue was reported to Google via the OSS VRP program
(Issue Tracker #543813782), and Google confirmed the vulnerability.
The fix adds bounds validation before the read.
Full test suite passes (425/425 tests).