Skip to content

Flip the default for explicitBindingConflictsWithInject to enabled. #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Flip the default for explicitBindingConflictsWithInject to enabled. #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/dagger/internal/codegen/compileroption/ProcessingEnvironmentCompilerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ public ImmutableList<String> aliases() {
* How to report that an explicit binding in a subcomponent conflicts with an {@code @Inject}
* constructor used in an ancestor component.
*/
EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(WARNING, ERROR, NONE),
EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(ERROR, WARNING, NONE),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would this matter?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order changes the default value -- the first value passed to the enum's constructor is the default value.

;

final ValidationType defaultType;
Expand Down
5 changes: 2 additions & 3 deletions javatests/dagger/internal/codegen/DuplicateBindingsValidationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,9 +1052,8 @@ public void childProvidesConflictsWithParentInjects() {
CompilerTests.daggerCompiler(foo, injected1, injected2, provided1, provided2)
.compile(
subject -> {
subject.hasErrorCount(0);
subject.hasWarningCount(1);
subject.hasWarningContaining(
subject.hasErrorCount(1);
subject.hasErrorContaining(
message(
"Foo is bound multiple times:",
" @Inject Foo(Set<String>) [Injected1]",
Expand Down