Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude original_data field from PartialEq comparison #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mr-Leshiy
Copy link

As original_data is not required to be set, used/initialised only in limited number of cases.
So to be still be consistent in comparison operation, I am suggesting to exclude original_data field from comparing implementation.
As a result it eliminates inconvenience to alway keep this field either empty or initialised to be able to properly compare two ProtectedHeaders instances at this moment.

Copy link

google-cla bot commented Nov 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@atezet
Copy link

atezet commented Feb 24, 2025

Could this PR be considered? I think it makes a lot of sense to ignore original_data when comparing ProtectedHeaders. I ran into this when testing whether writing then reading it from a database would still result in the original object.

@daviddrysdale
Copy link
Collaborator

This PR cannot be considered without a CLA from the author.

@atezet
Copy link

atezet commented Feb 24, 2025

@Mr-Leshiy would you be willing to sign the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants