Fix untrusted remote batch fuzz tasks to pass signed URLs - #5458
Conversation
a2b144b to
fb75754
Compare
fb75754 to
d3a30f0
Compare
| self.assertTrue(result) | ||
|
|
||
| def test_linux_fuzz_tworker_swarming(self): | ||
| """Tests that on an orchestration tworker, is_remote_utask returns False for |
There was a problem hiding this comment.
this confuses me but is the current behavior of the code. I guess swarming relies on different checks?
|
Assigning to the sheriff, but if anyone on your team has more context here outside of Javan feel free to reassign. I'm not too familiar with the architecture here |
|
For testing in dev, do you know what types of bots we have? Are they all remote batch? I'm not sure whether we have any trusted long running bots in dev |
I don't see any batch vms in clusterfuzz-development And then in the logs, I looked at the logs for a There's also a bunch of idle |
|
Ok, the batch bots in dev were down due to the pubsub topics being down. So I can see batch bots in dev picking up the fuzz task. however, there's still an issue: logs show that the signed URLs are still not getting passed into the uworker and the databundle is attempting to take the normal path and not untrusted path. I'm going to try to see what's wrong with this fix |
|
I found some logs where a tworker did successfully pass the signed URL to a batch bot. I think the batch bots that weren't getting the URLs in dev are due to the inconsistent configuration |
Ensure tworkers create signed URLs for fuzz tasks by changing
is_remote_utaskto evaluate fuzz tasks specifically based on architecture.Blackbox fuzzers on linux which require data bundles like
inferno_webbotandlokihardt_jshitterare broken because they can't access their data bundles. Before the batch migration was complete, they fetched it as trusted linux bots through gsutil. Now, the tworker doesn't generate a signed URL because the fuzz task is evaluating to UtaskLocalExecutor and so it is skipped, leaving the untrusted linux batch bot without the signed URLs for the data bundleThis is somewhat hardcoded to fuzz tasks, but the execution of fuzz tasks is unique.
Fixes b/556617562
Testing
I will push to dev and test this before merging.