Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct SDP_ALL_ATTRIBUTES_RANGE value #639

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Correct SDP_ALL_ATTRIBUTES_RANGE value #639

merged 1 commit into from
Feb 3, 2025

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Feb 3, 2025 •
edited
Loading

Since #629, search_attributes() takes a tuple of (begin, end) instead of (value, size), so this value should be altered as well.

@zxzxwu zxzxwu requested a review from barbibulle February 3, 2025 10:27
@zxzxwu zxzxwu closed this Feb 3, 2025
@zxzxwu zxzxwu reopened this Feb 3, 2025
@zxzxwu zxzxwu merged commit dedc0ac into google:main Feb 3, 2025
57 checks passed
@zxzxwu zxzxwu deleted the sdp branch February 4, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxzxwu @barbibulle