Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double-disable legacy advertising set #424

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Feb 4, 2024

When legacy advertising set is disabled passively(by set termination), the legacy advertising set won't be released, and the next stop_advertising() call will try to disable it again and cause an error.

@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Feb 4, 2024

The presubmit failure is due to #423.

@zxzxwu zxzxwu force-pushed the adv branch 2 times, most recently from 5b10549 to 971e35a Compare February 5, 2024 00:05
@zxzxwu zxzxwu closed this Feb 5, 2024
@zxzxwu zxzxwu reopened this Feb 5, 2024
bumble/device.py Show resolved Hide resolved
When legacy advertising set is disabled passively(by set termination),
the legacy advertising set won't be released, and the next
stop_advertising() call will try to disable it again and cause an error.
@zxzxwu zxzxwu merged commit 90f4926 into google:main Feb 6, 2024
51 checks passed
@zxzxwu zxzxwu deleted the adv branch February 4, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants