Use exec_script_allowlist in GN now that it is available.

This CL renames the gn dotfile variable `exec_script_whitelist` to `exec_script_allowlist`, in order to be more inclusive. Bug: chromium:40713186 Change-Id: Iaf5ef131a64f3189e675acfd090c7043c3138df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188240 Reviewed-by: Geoff Lang <[email protected]> Commit-Queue: Dirk Pranke <[email protected]> Commit-Queue: Geoff Lang <[email protected]>
google · Jan 22, 2025 · 072eec0 · 072eec0
1 parent 1d25be5
commit 072eec0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.gn b/.gn
@@ -26,8 +26,8 @@ script_executable = "python3"
 # These are the list of GN files that run exec_script. This allowlist exists
 # to force additional review for new uses of exec_script, which is strongly
 # discouraged except for gypi_to_gn calls.
-exec_script_whitelist = angle_dotfile_settings.exec_script_whitelist +
-                        build_dotfile_settings.exec_script_whitelist +
+exec_script_allowlist = angle_dotfile_settings.exec_script_allowlist +
+                        build_dotfile_settings.exec_script_allowlist +
                         [
                           "//build/config/sysroot.gni",
                           "//build/config/win/BUILD.gn",

diff --git a/dotfile_settings.gni b/dotfile_settings.gni
@@ -6,5 +6,9 @@
 # to make it easier to roll new versions of ANGLE in.
 
 angle_dotfile_settings = {
-  exec_script_whitelist = [ get_path_info("BUILD.gn", "abspath") ]
+  exec_script_allowlist = [ get_path_info("BUILD.gn", "abspath") ]
+
+  # TODO(crbug.com/389986807) - move other clients to `exec_script_allowlist`
+  # so that we don't need to keep supporting `exec_script_whitelist`.
+  exec_script_whitelist = exec_script_allowlist
 }