Improve the LaunchSingleInstance in cvd start#2812
Open
SuperStrongDinosaur wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the robustness of the single-instance boot (LaunchSingleInstance) in
cvd start:1. Fix Client Hang: Forwarded
--daemon=trueto therun_cvdsubprocess inLaunchSingleInstance. Previously,run_cvdwas launched without arguments, defaulting to the foreground, which caused the client to wait indefinitely for theVM to exit.
- Prevented bypass if the user requests foreground mode (
--daemon=false), sinceLaunchSingleInstancedoes not implement foreground log tailing.- Prevented bypass if any configuration-altering flags are passed (only
--daemonis considered safe), ensuringassemble_cvdis not skipped when config changes are requested.- Enforce that the main instance itself cannot bypass the full boot, and that the main instance must be in
RUNNINGstate before a secondary instance is allowed to use the fast-track bypass.