Skip to content

fix(workflow): prevent false positives in cli import check #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KrshnKush wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix(workflow): prevent false positives in cli import check #4048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f733240
Fix regex for forbidden import detection
KrshnKush Dec 30, 2025
d9a80d3
Merge branch 'main' into workflows
wuliang229 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check-file-contents.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
echo ""
set +e
FILES_WITH_FORBIDDEN_IMPORT=$(grep -lE '^from.*cli.*import.*$' $CHANGED_FILES)
FILES_WITH_FORBIDDEN_IMPORT=$(grep -lE '^from\s+([^ ]*\.)?cli(\s|\.)' $CHANGED_FILES)
GREP_EXIT_CODE=$?
Copy link
Collaborator

@wuliang229 wuliang229 Jan 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:

  1. Instead of "\s+", just match the space character " "
  2. don't match any pattern before "cli", just match optional "google.adk." or "adk.", i.e. (google.adk.)|(adk.)
  3. add back the matching of "import"

set -e
Expand All @@ -110,4 +110,4 @@ jobs:
fi
else
echo "✅ No relevant Python files found."
fi
fi