-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add customizable memory_service extension for get_fast_api_app #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @stonyme, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the get_fast_api_app
function by introducing a new parameter that allows developers to directly inject a custom memory service implementation. This change significantly improves the flexibility of the application's stateful memory management, enabling more tailored session and caching strategies without relying solely on URI-based configurations.
Highlights
- New Parameter: Introduced a
memory_service
parameter to theget_fast_api_app
function. - Custom Implementations: This new parameter allows for the injection of custom implementations for stateful memory storage.
- Enhanced Flexibility: The change provides greater flexibility for session management and caching strategies by enabling direct service injection.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Response from ADK Triaging Agent Hello @stonyme, thank you for creating this PR! To help reviewers evaluate your contribution, could you please associate a GitHub issue with this PR? If one doesn't exist, please create one that describes the feature you're adding. Also, could you add a This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a memory_service
parameter to get_fast_api_app
, allowing for dependency injection of a memory service. This is a good change for flexibility and testability. My main feedback is to use a more specific type hint for the new parameter instead of Any
. I also noticed that there are no new tests to cover the case where a custom memory_service
is passed to get_fast_api_app
. It would be beneficial to add a test case for this new functionality to ensure it works as expected.
feat: add customizable memory_service extension for get_fast_api_app
memory_service
parameter toget_fast_api_app
function