Skip to content

fix: Add required parameters with defaults if missing #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −0
Open

fix: Add required parameters with defaults if missing #2054

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1cbc9b5
Add required parameters with defaults if missing https://github.com/g…
jeffbryner Jul 19, 2025
14e64f2
only add parameter if missing
jeffbryner Jul 20, 2025
71d9645
Merge branch 'main' into fix-required-params
seanzhou1023 Jul 22, 2025
c60dd4e
fix: add required parameters if missing
jeffbryner Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,13 @@ async def call(

# Attach parameters from auth into main parameters list
api_params, api_args = self._operation_parser.get_parameters().copy(), args

# add any required arguments that are missing and have defaults:
for api_param in api_params:
if api_param.py_name not in api_args:
if api_param.required and api_param.param_schema.default:
api_args[api_param.py_name] = api_param.param_schema.default

if auth_credential:
# Attach parameters from auth into main parameters list
auth_param, auth_args = self._prepare_auth_request_params(
Expand Down