Fix state update #1104
Merged
Fix state update #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koverholt
approved these changes
Jan 5, 2026
Collaborator
koverholt
left a comment
koverholt
left a comment
There was a problem hiding this comment.
I tested this and with the changes it's updating the state correctly and working as expected. LGTM. Thanks for your contribution! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where session state updates were not persisting. The issue was that
get_session()returns a copy of the session object, so modifications tocurrent_session.state["topic"]were not reflected in the actual session. Whenrunner.run_async()retrieves the session later, it would still see the old topic value.The new code
current_session = session_service.sessions[APP_NAME][USER_ID][SESSION_ID]current_session.state["topic"] = user_input_topicwill really update the state.