Skip to content

fix: Close the html tag for the MultipleChoice component in Lit library. #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paullewis merged 1 commit into from
Jan 19, 2026
Merged

fix: Close the html tag for the MultipleChoice component in Lit library. #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion renderers/lit/src/0.8/ui/multiple-choice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export class MultipleChoice extends Root {
)}>
<label class=${classMap(
this.theme.components.MultipleChoice.label
)} for="data">${this.description ?? "Select an item"}</div>
)} for="data">${this.description ?? "Select an item"}</label>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly fixes the unclosed HTML tag, the repository's style guide requires that code changes are accompanied by tests. Adding a test case, such as a snapshot test, would verify the component's HTML structure and help prevent similar issues in the future.

References
  1. The repository style guide specifies that code changes should have corresponding tests. (link)

<select
name="data"
id="data"
Expand Down
Loading