Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update uploadFile method to accept both file paths and Buffers #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Maged-Zaki
Copy link

The code was refactored to accept both file paths and Buffers as inputs for uploading files with metadata. This change improves flexibility by eliminating synchronous file reads and allowing the in-memory ready buffer to be given to the uploadFile method instead of forcing developers to write the file locally and then read it again.

@Annhiluc Annhiluc added status:triaged Issue/PR triaged to the corresponding sub-team p2 labels Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 status:triaged Issue/PR triaged to the corresponding sub-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants