-
Notifications
You must be signed in to change notification settings - Fork 2k
Feat: Documenting 2.5 Flash thinking in REST/curl #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB nikitamaia commented on 2025-05-01T21:49:14Z empty link. maybe worth removing since flash 2.0 is not used in this notebook. andycandy commented on 2025-05-01T22:29:35Z Alright I removed that link. |
View / edit / reply to this conversation on ReviewNB nikitamaia commented on 2025-05-01T21:49:15Z None? andycandy commented on 2025-05-01T22:14:50Z Technically the response doesn't contain any |
View / edit / reply to this conversation on ReviewNB nikitamaia commented on 2025-05-01T21:49:15Z Here you say "you are fixing a value to the thinking budget" but in the payload below its set to 0. Can you clarify this? andycandy commented on 2025-05-01T22:24:20Z Apologies, it was a typo |
Apologies, it was a typo View entire conversation on ReviewNB |
Alright I removed that link. View entire conversation on ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you!
View / edit / reply to this conversation on ReviewNB nikitamaia commented on 2025-05-02T15:52:50Z actually one more thing, seems like this links back to the non rest example. andycandy commented on 2025-05-02T16:27:43Z Oh yeah, lemme fix that real quick. andycandy commented on 2025-05-02T16:33:55Z Fixed that! |
Oh yeah, lemme fix that real quick. View entire conversation on ReviewNB |
Fixing link
Fixed that! View entire conversation on ReviewNB |
Closes #723
Feat: