Update main branch with e2e #90
Conversation
the-scrambler
force-pushed
the
main-e2e
branch
from
c6b2b67 to
d1ae44d
Compare
johnshea
left a comment
johnshea
left a comment
There was a problem hiding this comment.
The status bar is not colored correctly in dark mode.
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| enableEdgeToEdge() |
There was a problem hiding this comment.
This should be before the super.onCreate() call.
| Surface( | ||
| modifier = Modifier.fillMaxSize(), | ||
| color = MaterialTheme.colorScheme.background | ||
| modifier = Modifier |
There was a problem hiding this comment.
This should be one line and not wrap.
| --> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@drawable/ic_launcher_background"/> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground"/> |
There was a problem hiding this comment.
Why is branch starter-e2e (has it) and this branch (doesn't have it) different regarding <monochrome android:drawable="@drawable/ic_launcher_foreground" />?
| --> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@drawable/ic_launcher_background"/> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground"/> |
There was a problem hiding this comment.
Why is branch starter-e2e (has it) and this branch (doesn't have it) different regarding <monochrome android:drawable="@drawable/ic_launcher_foreground" />?
There was a problem hiding this comment.
Is there a reason for getting a string resource two different ways 7 lines apart?
nit: It is the same string so possible refactor into one call.
No description provided.