chore: address concurrency warning on onPreferenceChange
#389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SDKs released with Xcode 16.2, Apple marked this closure `@Sendable`, but *not* `@MainActor`. It's not clear if this is intentional or if it may be revised later. The official recommendation appears to be capturing the `Binding` and writing to it (`Binding` is asserted to be `Sendable`). https://stackoverflow.com/questions/79209071/xcode-16-2-beta-2-renders-onpreferencechange-unusable
cweider
force-pushed
the
concurrency-on-preference-key
branch
from
94cc7b7 to
972fe63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SDKs released with Xcode 16.2, Apple marked this closure
@Sendable, but not@MainActor. It's not clear if this is intentional or if it may be revised later. The official recommendation appears to be capturing theBindingand writing to it (Bindingis asserted to beSendable).https://stackoverflow.com/questions/79209071/xcode-16-2-beta-2-renders-onpreferencechange-unusable