Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stan/70 edge test cases #109

Merged
merged 10 commits into from
Feb 3, 2025
Merged

Stan/70 edge test cases #109

merged 10 commits into from
Feb 3, 2025

Conversation

sczembor
Copy link
Contributor

Description

Closes: #70

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

@sczembor
update client mock
7c8f952 
Signed-off-by: sczembor <[email protected]>
@sczembor
update tidy
44468f1 
Signed-off-by: sczembor <[email protected]>
@sczembor
add info about the sr.ID
49e7f5d 
Signed-off-by: sczembor <[email protected]>
@sczembor
update errors
3c82fb1 
Signed-off-by: sczembor <[email protected]>
@sczembor
update todo
e08a04a 
Signed-off-by: sczembor <[email protected]>
@sczembor
tests: edge cases
946237e 
Signed-off-by: sczembor <[email protected]>
@sczembor sczembor requested review from robert-zaremba and vuvoth and removed request for robert-zaremba January 30, 2025 15:27
@sczembor sczembor marked this pull request as ready for review January 30, 2025 15:27
robert-zaremba
robert-zaremba reviewed Jan 30, 2025
View reviewed changes
ika/client_mock.go Outdated Show resolved Hide resolved
native2ika/processor_test.go Outdated Show resolved Hide resolved
sczembor and others added 3 commits January 30, 2025 17:30
@sczembor @robert-zaremba
Update ika/client_mock.go
d1b7ae0 
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: sczembor <[email protected]>
@sczembor
apply code review suggestions
b3a4f0d 
Signed-off-by: sczembor <[email protected]>
@sczembor
table tests
00a72ba 
Signed-off-by: sczembor <[email protected]>
vuvoth
vuvoth reviewed Jan 31, 2025
View reviewed changes
ika/client_mock.go Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
@sczembor @vuvoth
Apply suggestions from code review
a98c028 
Co-authored-by: Vu Vo <[email protected]>
Signed-off-by: sczembor <[email protected]>
@sczembor sczembor merged commit 0a9a49b into master Feb 3, 2025
10 checks passed
@sczembor sczembor deleted the stan/70-edge-test-cases branch February 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuvoth vuvoth vuvoth left review comments

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native->Bitcoin relayer: add edge cases in tests
3 participants
@sczembor @robert-zaremba @vuvoth