Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fork handle #35

Merged
merged 35 commits into from
Feb 19, 2025
Merged

feat: fork handle #35

merged 35 commits into from
Feb 19, 2025

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Feb 13, 2025 •
edited
Loading

Context

  • BTC fork handle mechanism
  • calc_work computation
  • Refactor storage

Close #8

vuvoth added 21 commits February 6, 2025 22:01
@vuvoth
manage block header storage
d6a9e6c 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
Merge branch 'master' into feat/vu-fork-handle
2cfba7a
@vuvoth
calculate block work
d97f877 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
update some test
9dd6fb2 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
update manage state
cc8c609 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
wip
10b426b 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
solve borrow issue
b5cecf7 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
wip
fdcc16f 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
refactor insert_header function (insert single header)
921f593 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
update error and rename function
9e43ee3 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
update test
f8d633f 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
testing
a4e7658 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
fix test
eddf6ef 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
add miss file
752c85b 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
calc_work tests
63799f7 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
rollback chain
60e9f33 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
fix params regtest mode
8342eee 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
test rollback function
08d93ca 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
remove events
69f9bd3 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
test insert header happy cases(wip)
0cc44ab 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
handle fork test and refactor code
516869b 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth marked this pull request as ready for review February 17, 2025 06:21
robert-zaremba
robert-zaremba reviewed Feb 17, 2025
View reviewed changes
sources/block_header.move Outdated Show resolved Hide resolved
sources/block_header.move Outdated Show resolved Hide resolved
sources/block_header.move Show resolved Hide resolved
sources/light_block.move Outdated Show resolved Hide resolved
sources/light_block.move Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Feb 17, 2025
View reviewed changes
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
tests/fork_tests.move Show resolved Hide resolved
@vuvoth @robert-zaremba
Apply suggestions from code review
90e1f7f 
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
vuvoth
vuvoth commented Feb 18, 2025
View reviewed changes
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Feb 18, 2025
View reviewed changes
sources/block_header.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
tests/fork_tests.move Show resolved Hide resolved
vuvoth and others added 7 commits February 19, 2025 14:01
robert-zaremba
robert-zaremba approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. There are few not-answered comments.

sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
sources/light_client.move Show resolved Hide resolved
sources/light_client.move Outdated Show resolved Hide resolved
vuvoth and others added 3 commits February 19, 2025 20:31
@vuvoth @robert-zaremba
Apply suggestions from code review
9cc36ff 
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
update
4c7e669 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth @robert-zaremba
Apply suggestions from code review
2b728e6 
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@robert-zaremba robert-zaremba merged commit e9cc78d into master Feb 19, 2025
1 check passed
@robert-zaremba robert-zaremba deleted the feat/vu-fork-handle branch February 19, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Bitcoin SPV: fork choice
2 participants
@vuvoth @robert-zaremba