Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify txn inclusive in block #19

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Jan 31, 2025

We can review this for now. However, it is better if we can do this after inserting header pr (#18).

Update:

  • Add more tests.
  • Refactor code.

Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth requested a review from robert-zaremba January 31, 2025 15:39
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

sources/bitcoin_spv.move Show resolved Hide resolved
sources/merkle_tree.move Outdated Show resolved Hide resolved
tests/bitcoin_spv_tests.move Outdated Show resolved Hide resolved
tests/bitcoin_spv_tests.move Outdated Show resolved Hide resolved
tests/bitcoin_spv_tests.move Outdated Show resolved Hide resolved
tests/bitcoin_spv_tests.move Outdated Show resolved Hide resolved
Move.lock Outdated Show resolved Hide resolved
vuvoth and others added 4 commits February 4, 2025 23:24
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth force-pushed the feat/verify-txn-inclusive-in-block branch from 7534170 to b9827e1 Compare February 4, 2025 16:32
@vuvoth vuvoth merged commit 5c61a16 into master Feb 4, 2025
1 check passed
@vuvoth vuvoth deleted the feat/verify-txn-inclusive-in-block branch February 4, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants