sdks/ts: replace any with proper types in SDK core#2857
Open
sdks/ts: replace any with proper types in SDK core#2857
Conversation
Replace `any` types with `unknown`, generics, and proper type constraints across the SDK. Uses Reflect.construct for safe instantiation, Object.assign for typed function objects, and generic wrappers for deserialize functions.
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement. Please read the CLA and post the comment below to sign. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anytypes withunknown, generics, and proper type constraints across ~15 SDK filesReflect.constructfor safe class instantiation in the decoratorObject.assignpattern for typed function objects in client generationdeserialize/deserializeDataValueto maintain public API types while usingunknowninternallyMethodKeys<T>helper type for cleanerClient<T>definitionMutableAgentStaticstype to avoid(ctor as any).get = ...patternContext
Split from #2845 based on reviewer feedback. This PR focuses only on SDK type improvements, excluding:
Test plan
tsc --noEmitpasses