Conversation
mschuwalow
approved these changes
Feb 17, 2026
Contributor
mschuwalow
left a comment
mschuwalow
left a comment
There was a problem hiding this comment.
Can confirm it works. A regression test would be nice though
Contributor
|
I would like to understand this before it gets merged (what is it fixing, and why - I thought that method is just a placeholder for IDE compeltion). |
Contributor
|
The problem was that patching the placeholder was done only after the constructor was called. Meaning using |
vigoo
approved these changes
Feb 18, 2026
Contributor
Author
|
Ok, this was never merged for a while, and the tests are failing too (which I am a bit surprised). I will take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2781
phantomId was failing because it delegates back to agentId. Fixed the issue, and now we can refer ids within constructor.