Skip to content

perf: nolint simplifications and improvements #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

scop
Copy link
Contributor

@scop scop commented Jun 1, 2025

See individual comments for details.

I have not run actual benchmarks on these exact changes, but from experience I expect them to show some performance and memory use improvements, in addition to the code being simpler.

scop added 2 commits June 1, 2025 10:51
As we are using a regex anyway for the initial pass, make use of capture
groups in it, instead of running the text through another regex and a
round of separate string parses.
@scop scop changed the title perf: nolint simplification and improvements perf: nolint simplifications and improvements Jun 1, 2025
@ldez ldez added the declined label Jun 1, 2025
@ldez ldez closed this Jun 1, 2025
@ldez
Copy link
Member

ldez commented Jun 1, 2025

nolint code is considered frozen.

@scop
Copy link
Contributor Author

scop commented Jun 2, 2025

That sounds odd to me. Anyway, just to make sure it did not go unnoticed, this PR contains changes to both nolint code, as well as nolintlint code. Are both frozen, or is the nolintlint change acceptable if I removed the nolint commit? Reopening for comments.

@scop scop reopened this Jun 2, 2025
@ldez ldez closed this Jun 2, 2025
@ldez
Copy link
Member

ldez commented Jun 2, 2025

They are both frozen because it's the same topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants