Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config path placeholder #5650

Merged
merged 3 commits into from
Apr 4, 2025
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 28, 2025

In the rare cases, the linter configuration should be relative to the configuration path, even when using other relative path modes other than cfg.

Those cases are relative to paths that reference "external files".

Fixes #5646

@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Mar 28, 2025
@ldez ldez added this to the v2-unreleased milestone Mar 28, 2025
@ldez ldez added the blocked: until next minor Will be a part of the next minor release label Mar 28, 2025
@ldez ldez removed this from the v2-unreleased milestone Mar 28, 2025
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a few tests?

@ldez ldez force-pushed the feat/config-placeholder branch from c47a4c7 to e7a9b27 Compare April 1, 2025 15:50
@ldez ldez force-pushed the feat/config-placeholder branch from e7a9b27 to 26a1e64 Compare April 4, 2025 00:22
@ldez ldez removed the blocked: until next minor Will be a part of the next minor release label Apr 4, 2025
@ldez ldez added this to the v2-unreleased milestone Apr 4, 2025
@ldez ldez force-pushed the feat/config-placeholder branch from 26a1e64 to 772f9ed Compare April 4, 2025 00:26
@ldez ldez merged commit e589139 into golangci:main Apr 4, 2025
19 checks passed
@ldez ldez deleted the feat/config-placeholder branch April 4, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate relative path mode for config vs output
3 participants