Skip to content

Correct misinformation in GO-2025-3783 #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correct misinformation in GO-2025-3783 #3878

wants to merge 1 commit into from

Conversation

cipherboy
Copy link

This vulnerability was incorrectly edited by GitHub staff without consulting the project. As noted in the original report, this affects the rotation endpoints on the server: it does not impact the client API package in any way.

This vulnerability was original to HashiCorp Vault thus the initial affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Resolves: #3877

@google-cla Google CLA
Copy link

google-cla bot commented Aug 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cipherboy cipherboy force-pushed the fix-GO-2025-3783-misinformation branch 2 times, most recently from ac3af68 to ccd5918 Compare August 12, 2025 16:44
@cipherboy
Copy link
Author

fyi @thatnealpatel @markus-kusano as you triaged #3783.

@gopherbot
Copy link
Contributor

This PR (HEAD: ccd5918) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vulndb/+/695295.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@cipherboy cipherboy force-pushed the fix-GO-2025-3783-misinformation branch 3 times, most recently from 02174b7 to 9fba31b Compare August 12, 2025 16:58
@gopherbot
Copy link
Contributor

This PR (HEAD: 9fba31b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vulndb/+/695295.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@cipherboy cipherboy force-pushed the fix-GO-2025-3783-misinformation branch from 9fba31b to 07b78f4 Compare August 19, 2025 12:58
@cipherboy
Copy link
Author

Thanks @markus-kusano, sorry, @gopherbot didn't tell me about CL comments.

@gopherbot
Copy link
Contributor

Message from Markus Kusano:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Markus Kusano:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 07b78f4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vulndb/+/695295.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@cipherboy cipherboy force-pushed the fix-GO-2025-3783-misinformation branch from 07b78f4 to 1c26612 Compare August 19, 2025 13:02
@gopherbot
Copy link
Contributor

Message from Alexander Scheel:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alexander Scheel:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 1c26612) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vulndb/+/695295.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Markus Kusano:

Patch Set 3: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ethan Lee:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@cipherboy
data/reports: correct GO-2025-3783
806644b 
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Fixes golang#3877

Signed-off-by: Alexander Scheel <[email protected]>
@cipherboy cipherboy force-pushed the fix-GO-2025-3783-misinformation branch from 1c26612 to 806644b Compare August 20, 2025 02:03
@gopherbot
Copy link
Contributor

This PR (HEAD: 806644b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vulndb/+/695295.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Alexander Scheel:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alexander Scheel:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/695295.
After addressing review feedback, remember to publish your drafts!

@cipherboy cipherboy closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markus-kusano markus-kusano Awaiting requested review from markus-kusano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/vulndb: suggestion regarding GO-2025-3783
2 participants
@cipherboy @gopherbot