Skip to content

feat: If the container exists, no pull is performed to speed up program execution #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

soulteary
Copy link

@soulteary soulteary commented Jun 26, 2022

At present, the program will try to download the latest version of the execution image every time it is started. Since we will definitely execute the image parameters during execution, we can directly start the program after checking the existence of the image without repeating the download.

@google-cla
Copy link

google-cla bot commented Jun 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: 0065931) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/playground/+/414334 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/414334.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Rakoczy:

Patch Set 1: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/414334.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from 苏洋:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/414334.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jenny Rakoczy:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/414334.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jenny Rakoczy:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/414334.
After addressing review feedback, remember to publish your drafts!

@soulteary soulteary force-pushed the feat/check-sandbox-image-exist branch from 0065931 to a6651aa Compare August 3, 2022 03:07
@gopherbot
Copy link
Contributor

This PR (HEAD: a6651aa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/playground/+/414334 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@soulteary
Copy link
Author

continue in this pr: #18

@soulteary soulteary closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants