bytes: add Buffer.Peek #73795

icholy · 2025-05-20T12:14:49Z

Fixes #73794

gopherbot · 2025-05-20T12:26:13Z

This PR (HEAD: a364508) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-20T12:33:49Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T12:41:29Z

Message from Ilia Choly:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T12:55:34Z

This PR (HEAD: 9183579) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-20T15:31:39Z

Message from Sean Liao:

Patch Set 3: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T20:42:38Z

This PR (HEAD: 567abed) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-22T23:43:59Z

Message from Sean Liao:

Patch Set 4: Commit-Queue+1 Hold+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T23:52:06Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-22T23:38:41Z","revision":"b0589a19d1e96dd39726918ec49caa9249dab1b6"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T23:52:07Z

Message from Sean Liao:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T23:52:07Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 674415) / tools on master (commit df501f0)

To reproduce, try gomote repro 8700266486796463937.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T23:52:08Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-23T11:35:57Z

This PR (HEAD: 1806ba6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-23T14:59:11Z

Message from Sean Liao:

Patch Set 5: Commit-Queue+1 Hold+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-23T14:59:12Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-23T14:46:42Z","revision":"d90d67e750f14ca0ec714d1431eb70513752fe1e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-23T14:59:13Z

Message from Sean Liao:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-23T14:59:14Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/x_website-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 674415) / website on master (commit 3989c3b)

To reproduce, try gomote repro 8700209361389253761.

Additional links for debugging:

test golang.org/x/website module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-23T14:59:14Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-29T20:42:23Z

Message from Sean Liao:

Patch Set 6: -Hold Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-29T20:50:42Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-29T20:35:17Z","revision":"b8e24dadc7562265cf492b9132b4213de6a0a616"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-29T20:58:33Z

Message from Sean Liao:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-29T20:58:34Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-29T20:58:34Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-29T21:39:19Z

Message from Sean Liao:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T15:24:35Z

This PR (HEAD: 4e17c21) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-30T15:34:36Z

Message from Ilia Choly:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:13:41Z

Message from Sean Liao:

Patch Set 7: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:13:42Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-30T16:01:02Z","revision":"3039cc01f506c13af4afa0c7fe5e54974820d3a4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:23:05Z

Message from Sean Liao:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:23:06Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/x_website-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 674415) / website on master (commit 8827586)

To reproduce, try gomote repro 8699570504559970897.

Additional links for debugging:

test golang.org/x/website module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:23:07Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-31T20:01:31Z

This PR (HEAD: d4fcf66) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Fixes golang#73794

gopherbot · 2025-10-31T20:11:08Z

This PR (HEAD: 3494d93) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/674415.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-31T20:19:55Z

Message from Sean Liao:

Patch Set 9: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-31T20:28:30Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-31T20:12:04Z","revision":"da9b22378e8706f0d4f12b328bc34f1a6068fcb0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-31T20:37:11Z

Message from Sean Liao:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-31T20:37:11Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-31T20:37:12Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-03T15:17:39Z

Message from Michael Knyszek:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/674415.
After addressing review feedback, remember to publish your drafts!

Fixes #73794 Change-Id: I0a57db05aacfa805213fe8278fc727e76eb8a65e GitHub-Last-Rev: 3494d93 GitHub-Pull-Request: #73795 Reviewed-on: https://go-review.googlesource.com/c/go/+/674415 Reviewed-by: Sean Liao <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Michael Pratt <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Michael Pratt <[email protected]>

gopherbot · 2025-11-03T17:44:45Z

This PR is being closed because golang.org/cl/674415 has been merged.

icholy force-pushed the buffer-bytes-peek branch from a364508 to 9183579 Compare May 20, 2025 12:48

icholy force-pushed the buffer-bytes-peek branch from 9183579 to 567abed Compare October 22, 2025 20:36

icholy force-pushed the buffer-bytes-peek branch from 567abed to 1806ba6 Compare October 23, 2025 11:31

icholy force-pushed the buffer-bytes-peek branch from 1806ba6 to 4e17c21 Compare October 30, 2025 15:19

icholy force-pushed the buffer-bytes-peek branch 2 times, most recently from 56ce607 to d4fcf66 Compare October 31, 2025 20:01

bytes: add Buffer.Peek

Loading
Loading status checks…

3494d93

Fixes golang#73794

icholy force-pushed the buffer-bytes-peek branch from d4fcf66 to 3494d93 Compare October 31, 2025 20:02

gopherbot closed this Nov 3, 2025

bytes: add Buffer.Peek #73795

bytes: add Buffer.Peek #73795

Conversation

icholy commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

gopherbot commented Oct 31, 2025

icholy commented May 20, 2025 •

edited

Loading