Skip to content

Conversation

fx408
Copy link
Contributor

@fx408 fx408 commented Sep 14, 2025

  • Before
    BenchmarkPointRegularPoints-12 1476942 810.5 ns/op 360 B/op 4 allocs/op

  • After
    BenchmarkPointRegularPoints-12 2055764 548.6 ns/op 192 B/op 1 allocs/op

Copy link
Collaborator

@alan-strohm alan-strohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 nits. Let me know if you'd prefer me to add commits to your fork for changes like this - I'm still getting used to github etiquette.

Disclosure: both of these were flagged by copilot, but I looked into them and they seem useful to address.

@fx408
Copy link
Contributor Author

fx408 commented Sep 17, 2025

Just 2 nits. Let me know if you'd prefer me to add commits to your fork for changes like this - I'm still getting used to github etiquette.

Disclosure: both of these were flagged by copilot, but I looked into them and they seem useful to address.

What do you need me to do? I also know very little about GitHub's rules.

@panmari panmari requested a review from alan-strohm September 17, 2025 06:32
@panmari
Copy link
Collaborator

panmari commented Sep 17, 2025

Thanks for the improvement! Only one small styleguid nit, otherwise LGTM.

I also marked Alan again for re-reviewing.

@panmari
Copy link
Collaborator

panmari commented Sep 17, 2025

Thanks for the quck fix, assigning @alan-strohm for taking a last look and merging.

@alan-strohm alan-strohm merged commit 64cb148 into golang:master Sep 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants