-
Notifications
You must be signed in to change notification settings - Fork 188
regularPointsForFrame: Allocate memory in one go #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 nits. Let me know if you'd prefer me to add commits to your fork for changes like this - I'm still getting used to github etiquette.
Disclosure: both of these were flagged by copilot, but I looked into them and they seem useful to address.
What do you need me to do? I also know very little about GitHub's rules. |
Thanks for the improvement! Only one small styleguid nit, otherwise LGTM. I also marked Alan again for re-reviewing. |
Thanks for the quck fix, assigning @alan-strohm for taking a last look and merging. |
Before
BenchmarkPointRegularPoints-12 1476942 810.5 ns/op 360 B/op 4 allocs/op
After
BenchmarkPointRegularPoints-12 2055764 548.6 ns/op 192 B/op 1 allocs/op