add check for page-size #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rizul Gupta <[email protected]>
Signed-off-by: Rizul Gupta <[email protected]>
Signed-off-by: Rizul Gupta <[email protected]>
|
Should I add such check for all |
|
yes |
Signed-off-by: Rizul Gupta <[email protected]>
Signed-off-by: Rizul Gupta <[email protected]>
Signed-off-by: Rizul Gupta <[email protected]>
|
merge conflicts |
Signed-off-by: Rizul Gupta <[email protected]>
|
conflicts resolved |
Vad1mo
approved these changes
Mar 25, 2025
Signed-off-by: Rizul Gupta <[email protected]>
Signed-off-by: Rizul Gupta <[email protected]>
Signed-off-by: Rizul Gupta <[email protected]>
rizul2108
added a commit
to rizul2108/harbor-cli
that referenced
this pull request
Apr 3, 2025
* add check for page-size Signed-off-by: Rizul Gupta <[email protected]> * fix lint error Signed-off-by: Rizul Gupta <[email protected]> * add page-size check for all list commands Signed-off-by: Rizul Gupta <[email protected]> * small fix Signed-off-by: Rizul Gupta <[email protected]> * fix lint error Signed-off-by: Rizul Gupta <[email protected]> * fix lint issues Signed-off-by: Rizul Gupta <[email protected]> * fix lint issues Signed-off-by: Rizul Gupta <[email protected]> --------- Signed-off-by: Rizul Gupta <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
rizul2108
added a commit
to rizul2108/harbor-cli
that referenced
this pull request
Apr 3, 2025
* add check for page-size Signed-off-by: Rizul Gupta <[email protected]> * fix lint error Signed-off-by: Rizul Gupta <[email protected]> * add page-size check for all list commands Signed-off-by: Rizul Gupta <[email protected]> * small fix Signed-off-by: Rizul Gupta <[email protected]> * fix lint error Signed-off-by: Rizul Gupta <[email protected]> * fix lint issues Signed-off-by: Rizul Gupta <[email protected]> * fix lint issues Signed-off-by: Rizul Gupta <[email protected]> --------- Signed-off-by: Rizul Gupta <[email protected]> Signed-off-by: Rizul Gupta <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes #341.
Before:
When setting the --page-size flag to values greater than 100 in list commands, the Harbor API returned a 422 error since the maximum allowed page_size is 100.
After:
Added a validation check to limit the --page-size flag to a maximum of 100, preventing the 422 error and ensuring consistent behavior across all list commands.