Skip to content

🚸 Execute go mod tidy after basic creation #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🚸 Execute go mod tidy after basic creation #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f82fb
feat: Exec `go mod tidy` after basic creation
valentimarco Dec 5, 2024
3f60284
Merge branch 'master' into feat/install_modules
grivera64 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmd/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,18 @@
return err
}

return runCmd(execCommand("go", "mod", "init", modName))
if err = runCmd(execCommand("go", "mod", "init", modName)); err != nil{

Check failure on line 89 in cmd/new.go

View workflow job for this annotation

GitHub Actions / Build (1.25.x, ubuntu-latest) 

undefined: err

Check failure on line 89 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

undefined: err

Check failure on line 89 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

undefined: err

Check failure on line 89 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: err

Check failure on line 89 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: err
return

Check failure on line 90 in cmd/new.go

View workflow job for this annotation

GitHub Actions / Build (1.25.x, ubuntu-latest) 

not enough return values

Check failure on line 90 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

not enough return values

Check failure on line 90 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

not enough return values

Check failure on line 90 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

not enough return values
}

//Execute go mod tidy in the project directory
installModules := execCommand("go", "mod", "tidy")
installModules.Dir = fmt.Sprintf("%s%c", projectPath, os.PathSeparator)
if err = runCmd(installModules); err != nil{

Check failure on line 96 in cmd/new.go

View workflow job for this annotation

GitHub Actions / Build (1.25.x, ubuntu-latest) 

undefined: err

Check failure on line 96 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

undefined: err

Check failure on line 96 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

undefined: err

Check failure on line 96 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: err

Check failure on line 96 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: err
return

Check failure on line 97 in cmd/new.go

View workflow job for this annotation

GitHub Actions / Build (1.25.x, ubuntu-latest) 

not enough return values

Check failure on line 97 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

not enough return values

Check failure on line 97 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

not enough return values

Check failure on line 97 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

not enough return values
}
Comment on lines +93 to +98
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix directory path construction

The directory path construction adds an extra separator character. The projectPath already contains the full path to the project.

Simplify the directory path assignment:

- installModules.Dir = fmt.Sprintf("%s%c", projectPath, os.PathSeparator)
+ installModules.Dir = projectPath
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
//Execute go mod tidy in the project directory
installModules := execCommand("go", "mod", "tidy")
installModules.Dir = fmt.Sprintf("%s%c", projectPath, os.PathSeparator)
if err = runCmd(installModules); err != nil{
return
}
//Execute go mod tidy in the project directory
installModules := execCommand("go", "mod", "tidy")
installModules.Dir = projectPath
if err = runCmd(installModules); err != nil{
return
}


return

Check failure on line 100 in cmd/new.go

View workflow job for this annotation

GitHub Actions / Build (1.25.x, ubuntu-latest) 

not enough return values

Check failure on line 100 in cmd/new.go

View workflow job for this annotation

GitHub Actions / govulncheck-check 

not enough return values

Check failure on line 100 in cmd/new.go

View workflow job for this annotation

GitHub Actions / lint 

not enough return values
}

const (
Expand Down
Loading