Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak mbedTLS handshake error message to be more useful #58807

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 5, 2022

  • Print error code in hexadecimal instead of decimal.
  • Point to the online list of mbedTLS error codes so users can figure out what went wrong.

TODO

- Print error code in hexadecimal instead of decimal.
- Point to the online list of mbedTLS error codes so users can figure
  out what went wrong.
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:network labels Mar 5, 2022
@Calinou Calinou added this to the 4.0 milestone Mar 5, 2022
@Faless
Copy link
Collaborator

Faless commented Mar 28, 2022

As far as I understand they are still in the process of moving the documentation, but for now this should have most of the SSL error codes:
https://tls.mbed.org/api/ssl_8h.html

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Aug 23, 2022
@akien-mga
Copy link
Member

Closing as this is an old draft that's not progressing. There's still a need to improve these messages, but so far I don't see a good way to do it. We could link to https://mbed-tls.readthedocs.io/projects/api/en/development/api/file/ssl_8h/?highlight=mbedtls_ssl_handshake#_CPPv421mbedtls_ssl_handshakeP19mbedtls_ssl_context, but as seen above they tend to change URLs, and their docs doesn't give the actual integer value for the error constants... so it's a pain to reverse engineer.

@akien-mga akien-mga closed this May 3, 2024
@AThousandShips AThousandShips removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 3, 2024
@akien-mga akien-mga removed this from the 4.x milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants