Revert "Optimize the callback argument of popup_create_dialog()" #113508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 251d037. Fixes godotengine#113498.
adamscott
approved these changes
Dec 3, 2025
AThousandShips
approved these changes
Dec 3, 2025
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
LGTM, let's circle back in 4.7 and get this done safely
Member
|
I know what's the problem, will make a fix soon. There is no need to revert so hastily. |
Contributor
|
Superseded by #113510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 251d037 / #106071.
Fixes #113498.