Disable shader baker when exporting as dedicated server

[Calinou]

Dedicated server exports don't perform any rendering, so there's no point in including baked shaders. Doing so saves a few MBs in PCK size if the shader baker was enabled in the export options.

• This closes Shader baker still exports a shader cache for dedicated server exports #109098.

Testing project: test_export_dedicated_server.zip

Preview

File sizes in bytes for ZIP main packs before and after this PR:

1799328 client_master.zip
1793511 client_pr.zip

1791818 server_master.zip
   2056 server_pr.zip

I exported as ZIP so it's easy to inspect, but you get similar savings in PCK too.

client_master.zip
client_pr.zip

server_master.zip
server_pr.zip

[clayjohn]

Shouldn't this just force disable "shader_baker/enabled" when using a dedicated server so that we don't have to add checks in multiple places?

[Calinou]

Shouldn't this just force disable "shader_baker/enabled" when using a dedicated server so that we don't have to add checks in multiple places?

Do you mean switching the export mode should automatically uncheck the shader_baker/enabled option if it's currently checked? This may lead to inconsistent state if you check it later on, unless we hide the checkbox while the export mode is set to Export as dedicated server.

If we can figure out a consistent way to do it, then it's probably a better idea.

[akien-mga]

Shouldn't this just force disable "shader_baker/enabled" when using a dedicated server so that we don't have to add checks in multiple places?

Do you mean switching the export mode should automatically uncheck the shader_baker/enabled option if it's currently checked? This may lead to inconsistent state if you check it later on, unless we hide the checkbox while the export mode is set to Export as dedicated server.

If we can figure out a consistent way to do it, then it's probably a better idea.

I think Clay was suggesting to replace:

if (p_preset->get("shader_baker/enabled")) {

with:

if (p_preset->get("shader_baker/enabled") && !p_preset->is_dedicated_server()) {

to always force skipping it without changing the configuration.
You'd add something like "The option is ignored when exporting as dedicated server." in the docs.

CC @dsnopek

[Calinou]

to always force skipping it without changing the configuration.

This seems to be already what the PR is doing, except I think Clay was referring to a different location in the code (not sure which one).