-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add AccessKit build instructions. #11460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
engine_details/development/compiling/compiling_for_linuxbsd.rst
Outdated
Show resolved
Hide resolved
engine_details/development/compiling/compiling_for_linuxbsd.rst
Outdated
Show resolved
Hide resolved
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge after addressing suggestions.
engine_details/development/compiling/compiling_for_linuxbsd.rst
Outdated
Show resolved
Hide resolved
engine_details/development/compiling/compiling_for_linuxbsd.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first AccessKit mention on each page should maybe be a link to either https://github.com/AccessKit/accesskit or https://accesskit.dev/ or what does everyone think?
Otherwise, this looks good to me.
Adds missing build instructions for build with AccessKit (Windows, Linux/BSD, macOS).
Also fixes wrong indent in ANGLE build instructions which was causing comments to be part of command block: