Add documentation about OpenXR spatial entities #11015
Conversation
AThousandShips
added
the
waiting on PR merge
There was a problem hiding this comment.
I noticed a few grammatical issues and typos so I wanted to make a review addressing some of them. I saw that it was also a commonality in this PR to omit commas after dependent clauses, so I left in 2 cases where I noticed it occurred, but I can go back and mark more where I noticed them.
|
Thanks for the feedback everyone, just to let you all know, I'm planning on updating this PR after we're certain about the API on the implementation PR just to minimize having to go back and forth on those changes. Will be updating this PR soonish |
BastiaanOlij
force-pushed
the
openxr_spatial_entities_docs
branch
7 times, most recently
from
a5b0b4a to
4edb00e
Compare
|
|
||
|
|
||
| ** | ||
| Q : Should we be doing update queries here to get position changes for markers?? |
There was a problem hiding this comment.
Mostly a reminder to myself, I need to add this in. We now do this in the built-in logic as well.
|
I think I covered all the comments, only some outstanding stuff around parameter naming which remains a problem. Also need to find some time to add update queries to the marker example. |
BastiaanOlij
force-pushed
the
openxr_spatial_entities_docs
branch
from
4edb00e to
e0bca81
Compare
BastiaanOlij
force-pushed
the
openxr_spatial_entities_docs
branch
from
e0bca81 to
73c533b
Compare
This PR adds documentation for the spatial entities implementation being added here: godotengine/godot#107391