-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Documentation for shader built-in include files (godotengine/godot#94193) #10703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
eecbe70
to
93fb248
Compare
Are you running your non-code text for this PR through a translator? |
I do run them through (freemium) Grammarly... |
93fb248
to
0afb5ab
Compare
To be clear, can I fix that CI error or should I wait? |
Please fix CI errors as soon as you can! |
I don't think that CI error is caused by this PR |
For future reference
|
There is a broken link in exporting_for_web.rst. Making an issue. |
What I found -> #10717 |
128bc02
to
011efad
Compare
Took a while, but reworked the example to be a pulsating transparent circle. The proposal now explains better what the example code does. |
At first glance, looks like a nice example for showing how shader includes work. I wonder if we should make more examples, or at least reference this once its merged: godotengine/godot-demo-projects#1086 There are plans to further break up and add built-in include files for our shader template logic. Those improvements will also unlock some interesting options with compositor effects. That is likely future music though but worth keeping in the back of our heads. |
One example is enough for now, just to get the feature documented in the first place. Examples are nice and all, but I would suggest that the bigger problem is how to know what includes have in them. I was thinking if I could try some PRs on this, I don't know. |
47764af
to
d2d9e0d
Compare
@AThousandShips Thank you :) |
951ca59
to
fff1efa
Compare
) Documents merged feature godotengine/godot#94193 to the end of the compute shader tutorial.
Documents merged feature godotengine/godot#94193 to the end of the compute shader tutorial.
If someone has a better example in mind I'm open to suggestions. I just wanted something short that does not have too much extra code around the include.