Skip to content

Add CMake file #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Add CMake file #57

merged 1 commit into from
May 29, 2025

Conversation

enetheru
Copy link
Contributor

@enetheru enetheru commented Oct 23, 2024

Adds a CMakeLists that builds against 4.4

@enetheru enetheru force-pushed the cmake branch 2 times, most recently from 1b09984 to 80aab92 Compare November 6, 2024 01:13
@enetheru
Copy link
Contributor Author

enetheru commented Nov 6, 2024

Since this this cmake solution tracks PR#1598 I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally I've been using this to make that happen:

git submodule set-url -- godot-cpp https://github.com/enetheru/godot-cpp.git
git submodule set-branch -b modernise godot-cpp
git submodule sync
git submodule update --init --recursive --remote

Edit: The above no longer applies, this pr is now synchronised to 4.4

@enetheru enetheru force-pushed the cmake branch 2 times, most recently from 4a16331 to fb3895b Compare March 4, 2025 04:36
@paddy-exe paddy-exe added the enhancement New feature or request label Mar 4, 2025
@paddy-exe
Copy link
Collaborator

Since this this cmake solution tracks PR#1598 I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally I've been using this to make that happen:

git submodule set-url -- godot-cpp https://github.com/enetheru/godot-cpp.git

git submodule set-branch -b modernise godot-cpp

git submodule sync

git submodule update --init --recursive --remote

I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp.

@enetheru
Copy link
Contributor Author

enetheru commented Mar 4, 2025

I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp.

I think I updated the submodule to 4.4 in this PR so I could test it.
I'm also working on CI for godot-cpp atm, should be helpful for when the same needs to happen here

@paddy-exe
Copy link
Collaborator

I think I updated the submodule to 4.4 in this PR so I could test it.

I'm also working on CI for godot-cpp atm, should be helpful for when the same needs to happen here

Sounds good as well👍🏻 in that case we can wait until your PR is in a mergeable state

@enetheru
Copy link
Contributor Author

I've updated godot-cpp submodule in this PR for the latest cherry picks in 4.4 as they are highly desired.
I minimised the solution too, rather than try to educate or add useful things, The only thing I have in here that's extra is that cmake will perform the git submodule update --init if the godot-cpp tree isnt populated.
I'm still waiting on approval of the CI for godot-cpp. But this is basically ready, if you like I can submit CI changes in a different PR.

@enetheru enetheru marked this pull request as ready for review March 20, 2025 03:47
Update module to track 4.4 branch with latest cherry picks.
@paddy-exe
Copy link
Collaborator

Hey @enetheru sorry for taking so long to respond to your last message. Can this PR be merged if I understand you correctly?

@enetheru
Copy link
Contributor Author

Hey @enetheru sorry for taking so long to respond to your last message. Can this PR be merged if I understand you correctly?

yeah

@paddy-exe paddy-exe merged commit 5513ce6 into godotengine:main May 29, 2025
23 checks passed
@paddy-exe
Copy link
Collaborator

Alright merged. Thank you @enetheru!

@enetheru enetheru deleted the cmake branch June 8, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants