Implement Gd::try_dynify.
#1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarwin
force-pushed
the
implement_gd_try_into_dyn
branch
from
e26700f to
7c45e5e
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1255 |
Yarwin
force-pushed
the
implement_gd_try_into_dyn
branch
from
7c45e5e to
c2ecacc
Compare
Yarwin
force-pushed
the
implement_gd_try_into_dyn
branch
2 times, most recently
from
bac8697 to
f72710a
Compare
Bromeon
reviewed
Aug 1, 2025
There was a problem hiding this comment.
Thank you!
So, try_xy() should always have the same semantics as xy() but returning Result/Option instead of panic. Since into_dyn is already taken, we need a different name.
Maybe try_dynify? Ideally a comment in docs would explain the relation + difference between the two.
godot-core/src/obj/gd.rs
Outdated
| @@ -512,6 +513,21 @@ impl<T: GodotClass> Gd<T> { | |||
| DynGd::<T, D>::from_gd(self) | |||
| } | |||
|
|
|||
| /// Tries to upgrade to a `DynGd<T, D>` pointer, enabling the `D` abstraction. | |||
| /// | |||
| /// If `T`'s class' dynamic type doesn't implement `AsDyn<D>`, `Err(self)` is returned, meaning you can reuse the original | |||
There was a problem hiding this comment.
"T's class' dynamic type" is a bit imprecise, since T is a compile-time type (given by the generic parameter). You probably mean the dynamic type of self?
There was a problem hiding this comment.
I meant the "original" class 🤔 – maybe "T's dynamic class"?
Yarwin
force-pushed
the
implement_gd_try_into_dyn
branch
from
f72710a to
0a500a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Gd::try_dynify, available for engine classes (currently we can validate if user-defined class implementsAsDyn<D>on compile time, thus makingtry_dynifypointless – just useinto_dyninstead).