-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
sources/saml: move SAML Response signature verification before decryption #18176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ntik#17607 to version-2025.10) (goauthentik#17620) website: fix active menu link background overlap (goauthentik#17607) Co-authored-by: Dominic R <[email protected]>
…ion-2025.10) (goauthentik#17627) Co-authored-by: authentik-automation[bot] <135050075+authentik-automation[bot]@users.noreply.github.com>
…y-pick goauthentik#17625 to version-2025.10) (goauthentik#17626) ci: use forked release action to deal with large release notes (goauthentik#17625) * ci: use forked release action to deal with large release notes * bump build --------- Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens L. <[email protected]>
…ry-pick goauthentik#17606 to version-2025.10) (goauthentik#17637) enterprise: add prometheus metrics for license usage and expiry (goauthentik#17606) Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens L. <[email protected]>
…y-pick goauthentik#17641 to version-2025.10) (goauthentik#17652) website/docs: rel notes 2025.10: add 3 more integration guides (goauthentik#17641) * add 3 more int guides * Apply suggestion from @dominic-r * is github's suggestion thingy usually this buggy --------- Signed-off-by: Dominic R <[email protected]> Co-authored-by: Tana M Berry <[email protected]> Co-authored-by: Tana M Berry <[email protected]> Co-authored-by: Dominic R <[email protected]>
…ik#17650 to version-2025.10) (goauthentik#17651) providers/proxy: drop headers with underscores (goauthentik#17650) drop any headers with underscores that we set in the remote system Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens L. <[email protected]>
…hentik#17657 to version-2025.10) (goauthentik#17672) website/docs: add note about invite link not bound (goauthentik#17657) * invite link not bound * marcelo's truth * jens tweak --------- Co-authored-by: Tana M Berry <[email protected]> Co-authored-by: Tana M Berry <[email protected]>
…hentik#17642 to version-2025.10) (goauthentik#17699) website/docs: eap add info about custom validation (goauthentik#17642) * add info about custom validation * tweaked table * remove bullet * remove other bullet --------- Co-authored-by: Tana M Berry <[email protected]> Co-authored-by: Tana M Berry <[email protected]>
…ntik#17700 to version-2025.10) (goauthentik#17701) Co-authored-by: Dominic R <[email protected]>
…oauthentik#17628 to version-2025.10) (goauthentik#17633) website/docs: add short-lived certificate recommendation (goauthentik#17628) Add certificate recommendation Co-authored-by: Dewi Roberts <[email protected]>
…k#17704 to version-2025.10) (goauthentik#17708) website/docs: blueprints: add a bit more info (goauthentik#17704) * website/docs: blueprints: add a bit more info * this might be worth mentioning * fix * a bit more info Co-authored-by: Dominic R <[email protected]>
… to version-2025.10) (goauthentik#17730) enterprise: handle cached naive timezone (goauthentik#17695) Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens L. <[email protected]>
…to version-2025.10) (goauthentik#17732) website/docs: update flow context ref (goauthentik#17723) * website/docs: update flow context ref * format * Update website/docs/add-secure-apps/flows-stages/flow/context/index.mdx * Update website/docs/add-secure-apps/flows-stages/flow/context/index.mdx --------- Signed-off-by: Jens Langhammer <[email protected]> Signed-off-by: Jens L. <[email protected]> Co-authored-by: Jens L. <[email protected]> Co-authored-by: Dominic R <[email protected]> Co-authored-by: Tana M Berry <[email protected]>
…#17728 to version-2025.10) (goauthentik#17733) website/docs: finalise 2025.10 release notes (goauthentik#17728) * website/docs: finalise 2025.10 release notes * format --------- Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens L. <[email protected]>
Sync. upstream.
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18176 +/- ##
===========================================
- Coverage 93.22% 55.49% -37.73%
===========================================
Files 933 933
Lines 51227 51264 +37
===========================================
- Hits 47754 28450 -19304
- Misses 3473 22814 +19341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PeshekDotDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a couple comments just saying "This is the fallback verification", etc?
Really appreciate you getting to this @ikob
We need some more test fixtures for fixing it. Co-authored-by: Connor Peshek <[email protected]> Signed-off-by: Katsushi Kobayashi <[email protected]>
…ion-2025.10) (goauthentik#17627) Co-authored-by: authentik-automation[bot] <135050075+authentik-automation[bot]@users.noreply.github.com>
Signed-off-by: Katsushi Kobayashi <[email protected]>
Details
When a SAML Response is encrypted, signature verification may fail because it is performed after decryption, when the original signed structure has changed.
This PR moves the verification step for signed responses to before decryption to handle encrypted signed responses correctly.
For backward compatibility, the post-decryption check remains as a fallback.
Hopefully close 405 errors at the step 4 of #16627
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)