Fix PlunderSwap plugin API: remove ignored tool parameter. #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
No issue/ticket.
Background
What does this PR do?
Removes
toAddress
parameter from theplunderswap_swap
tool: it is misleading to offer it because the tool ignores it.(For safety, the tool's actual implementation always deposits currency back into the user's wallet. We don't want the user accidentally giving somebody else the tokens because their address was in the conversation history.)
Testing
Use the instructions from the description of elizaOS/eliza#3267 to get going with ElizaOS. Locally, adjust
packages/plugin-zilliqa/package.json
to have ElizaOS'@goat-sdk/plugin-plunderswap
dependency link to wherever this branch'stypescript/packages/plugins/plunderswap
is.Try doing any swap with
plunderswap_swap
and see that the tokens are deposited back into your wallet.Detailed testing results
Links to transactions:
Docs
My changes do not require a change to the project documentation.
For plugins
Discord username
none