feat(storage): storage getInfo #351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 22 22
Lines 1635 1635
=======================================
Hits 1493 1493
Misses 106 106
Partials 36 36 🚀 New features to boost your workflow:
|
…into feat_test_report
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,41 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| package vela | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
3-41 lines are duplicate of vela/testreport.go:3-41 (dupl)
| @@ -0,0 +1,41 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| package vela | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
3-41 lines are duplicate of vela/testattachment.go:3-41 (dupl)
|
|
||
| import ( | ||
| "encoding/json" | ||
| "github.com/gin-gonic/gin" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gci)
|
|
||
| import ( | ||
| "encoding/json" | ||
| "github.com/gin-gonic/gin" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gci)
| // from the server methods of the Vela API. | ||
| AdminSettingsService service | ||
|
|
||
| // AdminStorageSettingsService handles managing admin storage settings functionality |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Comment should end in a period (godot)
| @@ -0,0 +1,58 @@ | |||
| package vela | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| @@ -0,0 +1,58 @@ | |||
| package vela | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| s := httptest.NewServer(server.FakeHandler()) | ||
| c, _ := NewClient(s.URL, "", nil) | ||
| c.Authentication.SetPersonalAccessTokenAuth("token") | ||
| data := []byte(server.StorageInfoResp) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (invalid statement above assign) (wsl_v5)
| if err == nil { | ||
| t.Errorf("GetInfo should have returned err %v", resp.StatusCode) | ||
| } | ||
| if resp.StatusCode != http.StatusUnauthorized { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (invalid statement above if) (wsl_v5)
| s := httptest.NewServer(server.FakeHandler()) | ||
| c, _ := NewClient(s.URL, "", nil) | ||
| c.Authentication.SetPersonalAccessTokenAuth("token") | ||
| data := []byte(server.TestReportResp) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (invalid statement above assign) (wsl_v5)
Functionality to retrieve storage credentials from server
Depends on go-vela/server#1271