Replace go-check with stretchr/testify#147
Open
tomyl wants to merge 2 commits intogo-stomp:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the test suite from
gopkg.in/check.v1togithub.com/stretchr/testify/require.go-checkmaybe made sense in the past but plaintesting.T+ an assertion library such asstretchr/testifyis a popular choice in modern Go code bases today. It's nice ifgo test -v -run xxxdoes what you expect.I manually migrated the tests and had Gemini 2.5 Pro review the diff.
I understand if nobody wants to review or merge this. Large diff and for some it's maybe simply not worth doing this. Also the choice of
stretch/testifymay not be obvious. Feel free to just close this PR without any comment.