Skip to content

Clean up input parameters in requireCheckFieldKind #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up input parameters in requireCheckFieldKind #1347

wants to merge 1 commit into from

Conversation

nodivbyzero
Copy link
Contributor

Fixes Or Enhances

This PR eliminates the defaultNotFoundValue input parameter since it consistently received a value of true.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner December 17, 2024 21:12
@coveralls
Copy link

Coverage Status

coverage: 74.318%. remained the same
when pulling 5289737 on nodivbyzero:require-check-field-kind-unparam
into 6c3307e on go-playground:master.

@nodivbyzero nodivbyzero requested a review from deankarn January 18, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn Awaiting requested review from deankarn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nodivbyzero @coveralls