Skip to content

dump: use mariadb-dump when available #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2024
Merged

dump: use mariadb-dump when available #942

merged 2 commits into from
Nov 11, 2024
+18 −8

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Nov 8, 2024 •
edited
Loading

Issue: ref #940 closes #264

  • Call mariadb-dump when there is no mysqldump in the execution path
  • This also fixes the issue that dump.NewDumper() might return nil, nil and go-mysqldump not checking for that.

@lance6716 lance6716 merged commit 37a3291 into go-mysql-org:master Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dump don't work anymore "exit status 7?"
2 participants
@dveeden @lance6716