Cleanup ActionRun creation #35624
Open
Cleanup ActionRun creation #35624
+71
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* share more logic
ChristopherHX
added
type/bug
type/refactoring
GiteaBot
added
the
lgtm/need 2
|
This shows how, worse the duplication is at the moment. Preparation for further refactoring. Maybe
At least the surface of doing code path specific inconsistent changes decreases and more tests cover the shared code than the specific code ever did. |
ChristopherHX
commented
Oct 11, 2025
| } | ||
|
|
||
| // FIXME PERF skip this for schedule, dispatch etc. | ||
| CreateCommitStatus(ctx, allJobs...) |
There was a problem hiding this comment.
old code conditonally didn't call this, nested function does the check
| } | ||
|
|
||
| // FIXME PERF do we need this db round trip? | ||
| allJobs, err := db.Find[actions_model.ActionRunJob](ctx, actions_model.FindRunJobOptions{RunID: run.ID}) |
There was a problem hiding this comment.
I wonder why we do not use job objects that insertrun creates? This db read seems like to not bring any advantage for me.
delvh
approved these changes
Oct 11, 2025
| "gopkg.in/yaml.v3" | ||
| ) | ||
|
|
||
| // PrepareRun prepares a run before inserting it into the database |
There was a problem hiding this comment.
Suggested change
| // PrepareRun prepares a run before inserting it into the database | |
| // PrepareRun prepares a run and inserts it into the database |
Before, it read to me like the caller should call InsertRun themselves, and I was confused where the InsertRun call is…
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35622