Skip to content

Remove unnecessary duplicate code #34552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

Remove unnecessary duplicate code #34552

merged 3 commits into from
Jun 3, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented May 28, 2025 •
edited
Loading

GetIssuesLastCommitStatus will revoke GetIssuesAllCommitStatus but it has been invoked. The CommitStatus template variable has never been used in notification subscription page so that it could be removed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 28, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2025
@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 28, 2025
@techknowlogick techknowlogick added this to the 1.25.0 milestone May 28, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) June 3, 2025 15:57
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 3, 2025
@techknowlogick techknowlogick merged commit 4e47148 into go-gitea:main Jun 3, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 3, 2025
@lunny lunny deleted the lunny/remove_duplicate_code branch June 3, 2025 18:21
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a2225b2 
* giteaofficial/main:
  Fix issue label delete incorrect labels webhook payload (go-gitea#34575)
  fixed incorrect page navigation with up and down arrow on last item of dashboard repos (go-gitea#34570)
  Remove unnecessary duplicate code (go-gitea#34552)
  Make pull request and issue history more compact (go-gitea#34588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @techknowlogick @hiifong @GiteaBot