Skip to content

Conversation

markwylde
Copy link

@markwylde markwylde commented Apr 26, 2025

Implements: #34289

Similar to ALLOWED_USER_VISIBILITY_MODES, this setting restricts which visibility modes (public, limited, private) can be selected for organizations.

  • Added new settings in service.go
  • Updated settings loading to parse the config
  • Modified org templates to filter visibility options
  • Added validation in controllers and service layer
  • Added translation for error message

Similar to ALLOWED_USER_VISIBILITY_MODES, this setting restricts which visibility
modes (public, limited, private) can be selected for organizations.

- Added new settings in service.go
- Updated settings loading to parse the config
- Modified org templates to filter visibility options
- Added validation in controllers and service layer
- Added translation for error message

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Apr 26, 2025
Similar to ALLOWED_USER_VISIBILITY_MODES, this setting restricts which visibility
modes (public, limited, private) can be selected for organizations.

- Added new settings in service.go
- Updated settings loading to parse the config
- Modified org templates to filter visibility options
- Added validation in controllers and service layer
- Added translation for error message
- Added tests for configuration loading and validation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@markwylde markwylde force-pushed the add-allowed-org-visibility-modes branch from afa57db to 93dd204 Compare April 26, 2025 11:43
@lunny
Copy link
Member

lunny commented Jun 18, 2025

The visibility change should be moved to danger zone after #34762 merged which maybe conflicted with this PR.

@markwylde
Copy link
Author

Thanks @lunny. I've pulled in main and tried to refactor it. Is there anything left to do on this?

@lunny
Copy link
Member

lunny commented Jun 21, 2025

Please wait #34814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants